search

serilog / serilog-sinks-email

A Serilog sink that writes events to SMTP email
Apache License 2.0
70 stars 68 forks source link

Allow use other types of mail transport like SqlServer #111

Closed krzysiek-b closed 6 months ago

krzysiek-b commented 1 year ago

Any chance this could get merged and released?

This seems to be really useful for us and lookink how much code changes are made there is no need to create another nuget project.

gfoidl commented 1 year ago

This should be in a different package, as it brings in a specific dependency (SQL Server) into a otherwise rather tech-agnositic package -- besides the core functionality of sending emails.

Where would this start and where end otherwise? I'd strongly prefer when this package is solely for sending emails (via Mailkit). Also users that don't need sending via SQL Server or SQL Server in general bring now in a dependency that they won't.

This package here could provide the needed abstractions to be implemented / overwritten in a specific Email.SqlServer package.

krzysiek-b commented 1 year ago

Hi @gfoidl agree :) I will move the dependency outside. Will it be okay?

gfoidl commented 1 year ago

Will it be okay?

For me: yes :-) If done please add a link to your package here (for reference). Thanks.

nblumhardt commented 6 months ago

Thanks for your PR! Hopefully you were able to get this published in a separate package; currently there's no plan to add additional transports here, due to scope/time constraints.