search

serilog / serilog-sinks-email

A Serilog sink that writes events to SMTP email
Apache License 2.0
70 stars 68 forks source link

Add extension as alternative for ICredentialsByHost #61

Closed ArnaudB88 closed 1 month ago

ArnaudB88 commented 5 years ago

Add extension with port, username and password parameters so they can be used from the configuration:

This is a fix for #58

mishamyte commented 5 years ago

@merbla, @MaximRouiller is this sink still being maintained?

This fix is pretty useful in the lot of cases. Would be nice it this pull request will be accepted.

MaximRouiller commented 5 years ago

I'll let @merbla handle those commits since he has merge rights to this project.

donhuff commented 5 years ago

@merbla @MaximRouiller +1 from me. This extension is useful to me as well as I am trying to keep all Serilog configuration in settings files.

ptmahoney commented 4 years ago

When might this appear in a new NuGet package? Not being able to configure the port in a config files is a big omission in today's world where ISP's are moving way from supporting port 25.

jwillmer commented 3 years ago

Any hope of getting this merged soon?

nblumhardt commented 1 month ago

Port configuration went in with 3.0; sorry about the lack of response on this @ArnaudB88, this project was low on maintainer time for a long stretch and things got shifted around a bit during the catch-up phase. Thanks again for the PR!