serilog / serilog-sinks-opentelemetry

A Serilog OpenTelemetry Protocol (OTLP) sink
Apache License 2.0
117 stars 19 forks source link

Record `SourceContext` in `InstrumentationScope.Name` #112

Closed nblumhardt closed 9 months ago

nblumhardt commented 11 months ago

See: https://github.com/open-telemetry/opentelemetry-dotnet/pull/4941

This should probably remove SourceContext from the regular set of attributes.

I'm uncertain whether all receivers will provide a pleasant consumption experience for instrumentation scope names, we might consider gating the new behavior on a (default-enabled) IncludedData.InstrumentationScopeName or similar, in the 1.x series of releases, so that the setting can be disabled and the old behavior restored if needed.