search

serilog / serilog-sinks-periodicbatching

Infrastructure for Serilog sinks that process events in batches.
Apache License 2.0
70 stars 29 forks source link

Set defaults when using PeriodicBatchingSinkOptions #40

Closed nblumhardt closed 4 years ago

nblumhardt commented 4 years ago

https://github.com/serilog/serilog-sinks-periodicbatching/pull/39#issuecomment-586532456

The chosen defaults are typical for networks sinks, but not universal.

skomis-mm commented 4 years ago

👍

nblumhardt commented 4 years ago

Thanks @skomis-mm :+1:

julealgon commented 4 years ago

Thanks for raising this. Setting the defaults is a good compromise. The fact that you documented the actual default values is welcome as well, as this is the first thing one looks for when manipulating these options classes.

nblumhardt commented 4 years ago

Thanks for taking a look, @julealgon 👍