serilog / serilog-sinks-periodicbatching

Infrastructure for Serilog sinks that process events in batches.
Apache License 2.0
70 stars 29 forks source link

Restore obsolete inheritance-based API #58

Closed nblumhardt closed 1 year ago

nblumhardt commented 1 year ago

3.0.0 removed the inheritance-based API; I think this was too hasty - although the corresponding functions/constructors were marked obsolete two years ago, that change didn't make it into a public release until around eight months ago, which hasn't allowed for enough actively-used but slow-moving sinks to migrate.

This change also ensures the wrapped sink is disposed whether the wrapper started or not; the original behavior (not disposing if !_started) is undesirable/unexpected, as far as I can see.