serilog / serilog-sinks-periodicbatching

Infrastructure for Serilog sinks that process events in batches.
Apache License 2.0
70 stars 29 forks source link

Batches not eagerly triggered when `BatchingOptions.BatchSizeLimit` is hit #65

Closed auriou closed 2 months ago

auriou commented 7 months ago

the property,

BatchingOptions.BatchSizeLimit= 100

does not work, it should trigger the sending of data when this limit is reached all as does

BatchExportProcessorOptions.MaxExportBatchSize = 100

who is in the OpenTelemetry.Exporter.OpenTelemetryProtocol

nblumhardt commented 7 months ago

Hi! This is inherited from Serilog.Sinks.PeriodicBatching and is a limitation of the design of that component. I'll move the issue over to its repository.

(There's no intention here that BatchSizeLimit would mirror anything in the OTel SDK.)

nblumhardt commented 2 months ago

This is done in 4.x