search

serilog / serilog-sinks-periodicbatching

Infrastructure for Serilog sinks that process events in batches.
Apache License 2.0
70 stars 29 forks source link

PeriodicBatchingSink Sealed #69

Closed aplato closed 4 months ago

aplato commented 4 months ago

The scope was changed again. I was inheriting from PeriodicBatchingSink. Several projects inherit from this class as well. I think this happened in 3.0.0 and was reverted in 3.1.*.

Is this intended behavior in 4.0 going forward or does it need to be reverted again?/

https://github.com/serilog-contrib/serilog-sinks-elasticsearch/issues/466

nblumhardt commented 4 months ago

PR'd a fix for this: https://github.com/serilog-contrib/serilog-sinks-elasticsearch/pull/579 - thanks for the heads-up.

nblumhardt commented 4 months ago

PR is merged. Does the latest prerelease build of Serilog.Sinks.Elasticsearch resolve this for you? Cheers!

aplato commented 4 months ago

All good. Thank you.

Verdurakh commented 4 months ago

I still have the same problem with Serilog.Sinks.Elasticsearch v 9.0.3 and Serilog.Sinks.PeriodicBatching v 4 Serilog v 3.1.1 where the PeriodicBatching is sealed.

what versions should I use to get this resolved?

Thanks

nblumhardt commented 3 months ago

Hi @Verdurakh - I'm not sure where the Elastic sink pre-release packages go or what their schedule is, I'm not a maintainer there. Asking over on that repo would be the way to go. HTH!