serilog / serilog-sinks-xamarin

A Serilog sink that writes events to Xamarin mobile targets
Apache License 2.0
55 stars 18 forks source link

Add basic Xamarin.Mac support #17

Closed chucker closed 4 years ago

chucker commented 4 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This uses NSLog on macOS the same way it was already used on iOS.

Does this PR introduce a breaking change?

Possibly!

I've rewritten the iOS project to use the new Sdk project style, and I've removed Xamarin-specific dependencies as they weren't being used and impeded the build process.

Therefore, you should test that logging from iOS actually still works. It should, though.

Please check if the PR fulfills these requirements

RLittlesII commented 4 years ago

@chucker Thank you for the contribution. Have you had the opportunity to test these changes? I will do my best to pull them down this week and give them a look.

chucker commented 4 years ago

@RLittlesII I have tested it on macOS. However, I have not been able to test if it breaks iOS.

RLittlesII commented 4 years ago

@chucker I am bringing this into a feature branch into the main repository so I can iterate on some clean up.

Thanks for your contribution!