serilog / serilog-sinks-xamarin

A Serilog sink that writes events to Xamarin mobile targets
Apache License 2.0
55 stars 18 forks source link

Make nuget package and sample work #4

Closed stefandevo closed 7 years ago

stefandevo commented 8 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Doc update and nuspec update

What is the current behavior? (You can also link to an open issue here)

The ; in the Readme where at the wrong position. The dependency on Newtonsoft.Json caused an issue with ios and android projects. Just removed because not necessary.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

Other information:

Please upload an update nuget package.

stefandevo commented 8 years ago

CI fails because of no Mac remote agent...

nblumhardt commented 8 years ago

Thanks @stefandevo - LGTM!

@ghuntley any thoughts on the CI aspect? Cheers!

ghuntley commented 7 years ago

Thanks @stefandevo for the PR. The CI defect was unrelated to this unit of work; latest version of Xamarin has dropped support for compiling 32bit libraries/applications and msbuild now throws exceptions. The sink was upgraded as part of #6 and the new release (v0.1.25) is now available on nuget.org.