seriohub / velero-helm

Helm charts for velero-ui, velero-api, and velero-watchdog
14 stars 6 forks source link

helm add annotation and tls ingresses #6

Closed rchekhina closed 4 months ago

rchekhina commented 5 months ago

HI,

On the helm chart can you add annotation and tls configuration please ?

to add the cert-manager cluster-issuer:

metadata:
 annotations:
    cert-manager.io/cluster-issuer: "letsencrypt-prod"

and the tls :

spec:
  tls:
  - hosts:
    - velero-ui.domain.com
    secretName: velero-ui-tls

Thanks in advance.

rchekhina commented 4 months ago

HI David,

thanks for this put you have removed the api ingress from the Chart.yml and the values.yml, is it normal ? I think that you need to do the same thing of ui for api.

Best regards.

davideserio commented 4 months ago

Hi,

We have implemented some changes to simplify the configuration. The API has been relocated to a new URL path prefix, so only a single ingress is needed.

For clarity:

I suggest utilizing the latest version of the Helm chart available (now v0.1.5) and the new values override file.

Please let us know if you encounter any problems.

rchekhina commented 4 months ago

HI David, ok thanks for the information. I have tried the tls configuration like following but it did not work. The annotation and the tls conf didnt appear on the ingress:

uiIngress:
  enabled: true
  # ingressClassName: nginx
  host: velero.domain.com
  tls:
    enabled: true
    metadata:
      annotations:
        cert-manager.io/cluster-issuer: "letsencrypt-prod" 
    spec:
      tls:
       - hosts:
         - velero.domain.com
         secretName: velero-ui-tls

can you help me please ?

davideserio commented 4 months ago

We have released a new version with various corrections. Please let us know if you encounter any problems or if the installation is successful.

rchekhina commented 4 months ago

HI Davide,

I confirm that now the annotation and tls config works like following:

uiIngress:
  enabled: true
  # ingressClassName: nginx
  host: velero.domain.com
  tls:
    enabled: true
  metadata:
    annotations:
      cert-manager.io/cluster-issuer: "letsencrypt-prod" 
  spec:
    tls:
     - hosts:
       - velero.domain.com
       secretName: velero-ui-tls

Best regards.