seriouslysean / monster-hunter-now-events

A tool that auto-generates calendar events for Monster Hunter Now by scraping web news articles, processing them with AI, and creating a convenient calendar subscription.
https://seriouslysean.github.io/monster-hunter-now-events/
MIT License
9 stars 9 forks source link

Updated README.md #39

Closed ISaumya1011 closed 11 months ago

ISaumya1011 commented 11 months ago

These are the changes against the issue #28 . Please check the changes. If any further changes need to be done, please let me know. N also, If you merge these changes, kindly accept my commits under hacktoberfest2023. Thank you!

Issue

Relevant issue number

Testing Steps

1.

Additional Information

1.

seriouslysean commented 11 months ago

Closing as a duplicate of #40. @ISaumya1011 you can just continue updating the same PR without the need to open and close new requests. Just push to the same branch.

Based on the naming of the branches, you’re making changes directly via GitHub. It might be worth learning to pull the changes down locally and using an editor instead.

https://code.visualstudio.com/docs/sourcecontrol/intro-to-git

Hope this helps!

ISaumya1011 commented 11 months ago

Hi @seriouslysean , Hope you are doing well. I had made the commits regarding the spellings n grammar, hope you recieved them. Kindly let me know other requirements regarding the same if any. Will work on them and let you know

seriouslysean commented 11 months ago

@ISaumya1011 hey! I left some pretty detailed feedback over on https://github.com/seriouslysean/monster-hunter-now-events/pull/40/files. Once you action on those it should be ok to merge.

ISaumya1011 commented 11 months ago

@ISaumya1011 hey! I left some pretty detailed feedback over on https://github.com/seriouslysean/monster-hunter-now-events/pull/40/files. Once you action on those it should be ok to merge.

Okay sure, I'll make the changes and complete the same in a day or two.

seriouslysean commented 11 months ago

Closed in favor of https://github.com/seriouslysean/monster-hunter-now-events/pull/50.