seriouslysean / monster-hunter-now-events

A tool that auto-generates calendar events for Monster Hunter Now by scraping web news articles, processing them with AI, and creating a convenient calendar subscription.
https://seriouslysean.github.io/monster-hunter-now-events/
MIT License
8 stars 9 forks source link

Add env for switching gpt models #44

Closed mdrokz closed 8 months ago

mdrokz commented 8 months ago

Issue

Resolves #41

Testing Steps

  1. I tested with gpt-3.5 turbo with no changes to the prompt it worked properly and fetched all the monster,habitat & dates info
mdrokz commented 8 months ago

This is really close, couple small suggestions. I also wonder if there’s a better way to switch between models. Right now it’s largely manual but we only really support 3.5 turbo and 4.

Otherwise this is really close! Thanks so much for all the work on this.

We can also provide cmd arguments if env file is not present, so people can pass a cmd arg like this ---model gpt-3.5 or --model gpt-4 like this. If this sounds good to you i could include it in this PR in the meantime i will work on the suggestions.

mdrokz commented 8 months ago

Hey i just pushed changes for the above suggestions

seriouslysean commented 8 months ago

I don’t think we need the arguments just now, only the env switch. Good future suggestion potentially, though.

seriouslysean commented 8 months ago

@mdrokz just fix the last couple lining issues and I’ll merge it!

mdrokz commented 8 months ago

@mdrokz just fix the last couple lining issues and I’ll merge it!

Do you mean the linting issues? İ see the GitHub check is failing

seriouslysean commented 8 months ago

@mdrokz yeah, you should be able to confirm by running the lint check locally. There’s even a fix script.

seriouslysean commented 8 months ago

@mdrokz looks like I closed it by accident, sorry. On vacation and doing a lot from my phone. 😬

mdrokz commented 8 months ago

@mdrokz yeah, you should be able to confirm by running the lint check locally. There’s even a fix script.

Cool let me do that

mdrokz commented 8 months ago

@mdrokz looks like I closed it by accident, sorry. On vacation and doing a lot from my phone. 😬

Haha no probs :)

mdrokz commented 8 months ago

Just pushed the lint fix