v1.0.0 - Githubissues

seripap / vainglory

(*DEPRECATED*: The API no longer exists, so this will no longer work) A Javascript API Client wrapper for Vainglory

MIT License

29 stars 7 forks source link

v1.0.0 #1

Closed seripap closed 7 years ago

seripap commented 7 years ago

TODO for a stable v1

[x] Add data models; getters and setters
[x] Better deserialization of JSON API
[x] Better Query formatting
[x] Collection modeling
[x] Parsing / formatting time
[x] Region support
[ ] Tests, Coverage over 75%
[x] Better examples

vaincoach commented 7 years ago

Awesome library - very helpful. Version 0.9.1 works for me, but updating to 0.9.2 gives me this: Error: Cannot find module 'vainglory'. I get this even when creating an empty project with only the vainglory dependency.

seripap commented 7 years ago

@vaincoach sorry about that- pull down v0.9.4 and it should resolve. thanks for the report!

vaincoach commented 7 years ago

Works perfectly now on v0.9.4 - thanks for your help.