search

seripap / vainglory

(*DEPRECATED*: The API no longer exists, so this will no longer work) A Javascript API Client wrapper for Vainglory
MIT License
30 stars 7 forks source link

5v5 Items #30

Closed PierreAndreis closed 6 years ago

PierreAndreis commented 6 years ago

Missing from last pr.

@seripap This should be asap

PierreAndreis commented 6 years ago

They are currently different. 5v5 is Flaregun Loader

On Jan 31, 2018, 4:47 PM -0800, Chris Klugewicz notifications@github.com, wrote:

The 5v5 flare gun returns the same common name as the 3v3 flare gun, though the items are different. Can we add something to distinguish them, please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cklugewicz commented 6 years ago

Yep, saw that — removed my request already! XD

Sent from my iPhone

On Jan 31, 2018, at 7:57 PM, Pierre Ortega notifications@github.com wrote:

They are currently different. 5v5 is Flaregun Loader

On Jan 31, 2018, 4:47 PM -0800, Chris Klugewicz notifications@github.com, wrote:

The 5v5 flare gun returns the same common name as the 3v3 flare gun, though the items are different. Can we add something to distinguish them, please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

PierreAndreis commented 6 years ago

@seripap hey, 5v5 casual will be dropping likely tonight (PST). Is it possible to have this PR merged before?

seripap commented 6 years ago

Released on v1.3.8

cklugewicz commented 6 years ago

Hey, guys, *Item_TotemEnhancer* is actually SuperScout 2000 in-game, not SuperScout