search

seripap / vainglory

(*DEPRECATED*: The API no longer exists, so this will no longer work) A Javascript API Client wrapper for Vainglory
MIT License
29 stars 7 forks source link

Removing Runtime Babel Dependency #35

Open PierreAndreis opened 6 years ago

PierreAndreis commented 6 years ago

I have update babel presets to the latest, removed all runtime babel dependency and republished it

I have also raised the requirements to node 6.

Reason is because most of the ES5/6 stuff are already supported by Node 6, there is no need for run time babel. It just makes the application slower with the addition of numerous boilerplates

seripap commented 6 years ago

Thanks, I'll have time this weekend to take a look and get back to you

PierreAndreis commented 6 years ago

@seripap If this is a major change, I could also get this opportunity to work on others requested features such as #28 #10

seripap commented 6 years ago

@PierreAndreis sure thing, feel free to tackle whatever you can assist with 👍

seripap commented 6 years ago

Any updates on your side for more changes? I may actually re-work portions so that babel is removed entirely. A lot of things are supported natively these days and it doesn't make sense to babelify a server side library

PierreAndreis commented 6 years ago

@seripap I haven't made any change so far, but I agree with you on removing babel completely. Only babel exclusive that node doesn't support yet is import/export (which babel is compiling to require... so no difference)

PierreAndreis commented 6 years ago

I can work on some changes tonight. Basically I want to get a .JSON() method for each class so we can get a json including getter/setter which would fix https://github.com/seripap/vainglory/issues/10