search

serizba / salad

Optimal Transport Aggregation for Visual Place Recognition
GNU General Public License v3.0
140 stars 13 forks source link

Releasing the model on torch.hub? #1

Closed gmberton closed 7 months ago

gmberton commented 7 months ago

Hi there, great work, and thanks for open sourcing! Are there any plans to release the trained model on torch.hub? It is quite simple to do and allows people to use your model with two lines of code, allowing more people to use your model and helping to spread your work! For example I did it for CosPlace, and the trained model can be automatically downloaded from anywhere without cloning the repo just like this

import torch
model = torch.hub.load("gmberton/cosplace", "get_trained_model", backbone="ResNet50", fc_output_dim=2048)
serizba commented 7 months ago

Hi @gmberton!

Thanks for your tip! I've updated the repo with a hubconf.py and added an example in the README. Hope this helps!

Thanks!

gmberton commented 7 months ago

Thanks for the quick response! I've added SALAD to this VPR benchmarking repo, having the model on torch.hub made it really easy. And congrats on the results!