serkonda7 / vscode-vba

VBA language extension to use with VS Code. Also used for syntax highlighting on GitHub.
https://marketplace.visualstudio.com/items?itemName=serkonda7.vscode-vba
Mozilla Public License 2.0
34 stars 12 forks source link

Highlight all parts of the Open statement #99

Open serkonda7 opened 9 months ago

serkonda7 commented 9 months ago

Description and Reproduction Steps

Not all parts of the open statement are yet highlighted.

https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/open-statement

Current Behavior

x

Expected Behavior

X

Additional Information

A valid concern was raised in https://github.com/serkonda7/vscode-vba/issues/96#issuecomment-1830082141:

In my opinion, it's not necessary to highlight the mode and access keywords inside the Open statement. Otherwise, the whole line of code is pretty much highlighted and I feel like too much highlighting is almost like no highlighting at all.

That being said, I'm not totally opposed to the idea, but that will need some more playing around with regex to make it work.

I think, we could use the alternate highlight color (e.g. purple) instead of the default blue keyword one. But otherwise a almost completely colored line in fact defeats it's purpose.

That being said, this issue is not yet decided on.

Environment details

X