search

serkri / SmartEVSE-3

Smart Electric Vehicle Charging Station (EVSE)
MIT License
68 stars 28 forks source link

fix mainsmeter date/time alignment and control box right margin #138

Closed daninden closed 1 year ago

daninden commented 1 year ago

Some minor layout fixes for the local web-ui: Before image After image

Before image After image

dingo35 commented 1 year ago

This is my problem with that html stuff Dan, it looks differently on every device (Android vs Ubuntu), on every browser, so it seems. This is what your PR shows at my screen: afbeelding

...and on my phone it is even worse: Screenshot_20230508_121417_Firefox Nightly

daninden commented 1 year ago

yeah the html is a bit of a mess, the version before my fix will probably give you almost the same weird layout issues. The only thing I changed is that the date and time where in the same row, they are in seperate rows now, just like the other labels.

dingo35 commented 1 year ago

Well it doesnt make things worse. For some reason you only changed a few lines, but the diff shows a whole block of differences. Could you please minimize the changes so it becomes clear what effectively changed?

I'll merge it right after that...

daninden commented 1 year ago

the merge got confused because i added a wrapper div for the show/hide. I removed the wrapper, added new show/hide for the additional row.