serkri / SmartEVSE-3

Smart Electric Vehicle Charging Station (EVSE)
MIT License
68 stars 28 forks source link

Improved modem functionality #153

Closed ArendJanKramer closed 1 year ago

ArendJanKramer commented 1 year ago

This PR features:

Work todo:

Please review and merge pr, rather than copy/pasting code. IMO git is not meant for copy-paste. I'm happy to make changes or to add code/docs where needed.

dingo35 commented 1 year ago

@ArendJanKramer I'm afraid I'm going to have to revert your code; it prevents charging when Modem = Not present, so it looks like you never even tested without modem/pyplc present?

ArendJanKramer commented 1 year ago

@ArendJanKramer I'm afraid I'm going to have to revert your code; it prevents charging when Modem = Not present, so it looks like you never even tested without modem/pyplc present?

It works fine here? Normal, smart and solar seem to work, although solar is waiting as its dark here.

afbeelding

dingo35 commented 1 year ago

Perhaps EV dependent? My EV didnt charge last evening, didnt have time to look at it, reverted theast commit and there it went. No EV here today so I cant try....

dingo35 commented 1 year ago

@ArendJanKramer False alarm, I cannot reproduce the problem, it charges fine now. Might have been the EV, there are quite some bugs in my cars firmware and VAG has problems getting their software development trajectory right.... Still waiting for the firmware update that will enable modem communication....