Move models into ~/schema

serlo / api.serlo.org

Public GraphQL API of https://serlo.org/

https://api.serlo.org/___graphql

Apache License 2.0

15 stars 4 forks source link

Move models into ~/schema #1410

Open kulla opened 6 months ago

kulla commented 6 months ago

After the refactoring we want to remove ~/model. There are some Models which should be easily migrateable into ~/schema:

[x] #1594
[ ] https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/model/google-spreadsheet-api.ts
[ ] https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/model/kratos.ts
[ ] https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/model/mailchimp.ts

AndreasHuber commented 6 months ago

I would prefer migrating https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/model/ai.ts directly into the frontend instead.

kulla commented 5 months ago

I would prefer migrating https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/model/ai.ts directly into the frontend instead.

I am with you that this is might be a good simplication. However the backend in the frontend does not know about kratos / our users. So checking whether the user has the rights to do the prompt is not easy to be done yet.