search

serlo / api.serlo.org

Public GraphQL API of https://serlo.org/
https://api.serlo.org/___graphql
Apache License 2.0
15 stars 4 forks source link

Use discussionsEnabled setting on pages #162

Closed elbotho closed 3 years ago

elbotho commented 3 years ago

There is a setting "discussionsEnabled" on static pages. Threads should only be returned if this is set to true.

(https://github.com/serlo/frontend/issues/709)

elbotho commented 3 years ago

(not sure if this is a api or serlo.org issue)

kulla commented 3 years ago

(not sure if this is a api or serlo.org issue)

Both. At legacy serlo.org this property needs to be added to /api/uuid and here it needs to be added to the Page type.

kulla commented 3 years ago

I noticed that comments are only enabled in few static pages -> I want to ask whether this feature is really needed or whether can can delete it and do not enable discussion at any static pages.

elbotho commented 3 years ago

@kulla Thanks for checking. This is what we did in the frontend for now. Do you know what pages it affects? @yolo-bird or @kathongi do you have an opinion here?

elbotho commented 3 years ago

Our favourite solution is to ignore this feature and remove it in the future. There are other ways (we could add a static list of pages that support threads to the api) so if someone argues we need this feature, please reopen.