serlo / backlog

1 stars 0 forks source link

Filter sandbox entities and taxonomies from quickbar #316

Open hugotiburtino opened 1 year ago

hugotiburtino commented 1 year ago

Not to do with CF Worker, but we haven't a place to put this issue, so I've left it here. Before that:

elbotho commented 1 year ago

Notes:

hugotiburtino commented 1 year ago

Robots are handled in frontend atm.

How is that? If I go to https://serlo.org/robots.txt I see exactly the result from https://github.com/serlo/cloudflare-worker/blob/main/src/robots.ts and not from https://github.com/serlo/frontend/blob/staging/public/robots.txt

Why should taxonomies not be indexed?

First of all, I think it is easier to do so: we just have to query all children from 106082, independent if it is entity or taxonomy, and disallow them. Besides that, I think it is safier so: for instance someone searchs for 'serlo test' in google but ends up at https://de.serlo.org/community/246612/test. ~But anyway, TODO:~ ~- [ ] Ask to stakeholders if they really want that sandbox taxonomies show up in searchs~

elbotho commented 1 year ago

Sorry, I misunderstood the title. sandbox taxonomies should not be indexed that is correct. Currently the frontend adds <meta name="robots" content="noindex"> for all sandbox entities and also trashed entities, empty pages, user profiles etc.

hugotiburtino commented 1 year ago

Currently the frontend adds for all sandbox entities

Wonderful, it is an important information. Thanks

It means this issue has nothing to do with cloudflare worker. But I'll leave it here to remember us to transfer the repo for quickbar