Allow notifications in new frontend for staging

serlo / cloudflare-worker

Cloudflare worker which works as a proxy for https://serlo.org/

Apache License 2.0

9 stars 1 forks source link

Allow notifications in new frontend for staging #85

Closed elbotho closed 3 years ago

elbotho commented 3 years ago

Notifications are supported in the new frontend under /user/notifications but it seems the CF worker does not know about it and we end up with "Diese Seite existiert nicht!" in the legacy system.

Steps (all with enabled frontend):

does not work: directly access https://de.serlo-staging.dev/user/notifications
does work: navigate to notifications via menu (using client side redirect).
does not work: refresh notifications page once you are there

kulla commented 3 years ago

@elbotho Am I right, that de.serlo.org/user/notifications needs to be redirected to frontend.serlo.org/de/user/notifications?

elbotho commented 3 years ago

yes, but only in staging for now.

kulla commented 3 years ago

@elbotho Fixed in https://github.com/serlo/serlo.org-cloudflare-worker/pull/89 deployed in staging -> can you test it there?

elbotho commented 3 years ago

Perfect, thank you very much!

kulla commented 3 years ago

Let's wait for the code review (PR still needs to be merged) :smile: