search

serlo / cloudflare-worker

Cloudflare worker which works as a proxy for https://serlo.org/
Apache License 2.0
9 stars 1 forks source link

Render license details in the new frontend #86

Closed Entkenntnis closed 3 years ago

Entkenntnis commented 3 years ago

See https://de.serlo-staging.dev/license/detail/1, the frontend should be ready, but it's somehow not working yet, also need to check CF worker.

elbotho commented 3 years ago

Jup, works fine with CSR even on production. So this is most likely just the worker. Moving issue.

kulla commented 3 years ago

Is it okay when this site renders in the new frontend also in production (for the ~10% of user in production who have the luck of getting the new frontend)?

Entkenntnis commented 3 years ago

Yes, this should be fine

kulla commented 3 years ago

@dal Fix in https://github.com/serlo/serlo.org-cloudflare-worker/pull/90 which is deployed in staging. There you can test it.

Entkenntnis commented 3 years ago

Thank you. We can then deploy to production with 25% Frontend