serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
35 stars 9 forks source link

Open entity links in /discussions in new tab #2658

Closed Entkenntnis closed 11 months ago

Entkenntnis commented 11 months ago

This should allow people to go back to the discussions page more easily.

elbotho commented 11 months ago

To be honest: I don't really support this change from my old-school webdesign perspective (and also from a ux perspective :) Bit of context in https://www.nngroup.com/articles/new-browser-windows-and-tabs/

Entkenntnis commented 11 months ago

unfortunately, the back-button is broken in this situation and you will loose your scroll position on /discussions.

It's always about tradeoffs :/

Entkenntnis commented 11 months ago

closing it for now as there are on-going discussions

elbotho commented 11 months ago

unfortunately, the back-button is broken in this situation and you will loose your scroll position on /discussions.

I'm mean that's a good point. If we can't find a feasible fix for that I'm okay with a hack.

Entkenntnis commented 11 months ago

(will reopen if we decided on it within the feature team)