search

serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
36 stars 9 forks source link

refactor(taxonomy): Remove `taxonomyId` #3884

Closed kulla closed 1 month ago

kulla commented 1 month ago

After https://github.com/serlo/db-migrations/issues/346 there is no taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete the quest of it in the query so that I can delete this field in the API in https://github.com/serlo/api.serlo.org/pull/1561

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jun 12, 2024 3:37pm
github-actions[bot] commented 1 month ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.4 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 489.88 KB (🟢 -318 B) 594.28 KB
/biologie 158.56 KB (🟢 -25 B) 262.96 KB
/chemie 158.56 KB (🟢 -25 B) 262.96 KB
/entity/create/[type]/[taxonomyId] 491.24 KB (🟢 -553 B) 595.64 KB
/entity/repository/add-revision/[...id] 490.46 KB (🟢 -548 B) 594.86 KB
/entity/taxonomy/update/[id] 67.88 KB (🟢 -28 B) 172.28 KB
/event/history 130.85 KB (🟢 -62 B) 235.25 KB
/event/history/[...slug] 131.85 KB (🟢 -62 B) 236.25 KB
/event/history/user/profile/[username] 134.28 KB (🟢 -62 B) 238.68 KB
/informatik 158.56 KB (🟢 -25 B) 262.96 KB
/lerntipps 158.56 KB (🟢 -25 B) 262.96 KB
/mathe 158.56 KB (🟢 -25 B) 262.96 KB
/nachhaltigkeit 158.57 KB (🟢 -25 B) 262.97 KB
/page/create 490.48 KB (🟢 -545 B) 594.88 KB
/subscriptions/manage 112.7 KB (🟢 -25 B) 217.1 KB
/taxonomy/term/create/[parent_id]/[id] 490.17 KB (🟢 -544 B) 594.57 KB
/taxonomy/term/update/[id] 490.09 KB (🟢 -542 B) 594.49 KB
/user/notifications 133.15 KB (🟢 -62 B) 237.55 KB
/user/profile/[username] 177.25 KB (🟢 -62 B) 281.65 KB
/user/settings 489.12 KB (🟢 -318 B) 593.51 KB
/uuid/recycle-bin 85.06 KB (🟢 -25 B) 189.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 1 month ago

user journey is now merged into staging and we should not have to keep this branch up to date