serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
35 stars 9 forks source link

fix(dropzone-image): relative position and layout #3894

Closed hejtful closed 2 weeks ago

hejtful commented 3 weeks ago

Done:

demo in editor preview

demo in article

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jun 19, 2024 8:21pm
github-actions[bot] commented 3 weeks ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.16 KB (🟡 +114 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 82.59 KB (-1 B) 186.75 KB
/___bot_or_not 96.84 KB (-1 B) 201 KB
/___editor_preview 506.94 KB (🟡 +422 B) 611.1 KB
/biologie 159.59 KB (-9 B) 263.75 KB
/chemie 159.59 KB (-9 B) 263.75 KB
/content-only/[...slug] 75.06 KB (-1 B) 179.22 KB
/editor 107.58 KB (-1 B) 211.74 KB
/entity/create/[type]/[taxonomyId] 507.9 KB (🟡 +424 B) 612.06 KB
/entity/repository/add-revision/[...id] 507.16 KB (🟡 +420 B) 611.32 KB
/entity/repository/compare/[entity_id]/[revision_id] 87.52 KB (-1 B) 191.68 KB
/event/history 131.14 KB (-8 B) 235.3 KB
/event/history/[...slug] 132.13 KB (-8 B) 236.29 KB
/event/history/user/profile/[username] 134.51 KB (-8 B) 238.67 KB
/informatik 159.59 KB (-9 B) 263.75 KB
/lerntipps 159.59 KB (-9 B) 263.75 KB
/license/detail/[id] 59.83 KB (-1 B) 163.99 KB
/mathe 159.59 KB (-9 B) 263.75 KB
/nachhaltigkeit 159.6 KB (-9 B) 263.75 KB
/page/create 507.19 KB (🟡 +422 B) 611.35 KB
/subscriptions/manage 113.91 KB (-8 B) 218.07 KB
/taxonomy/term/create/[parent_id]/[id] 506.96 KB (🟡 +428 B) 611.12 KB
/taxonomy/term/update/[id] 506.9 KB (🟡 +431 B) 611.06 KB
/user/notifications 133.39 KB (-8 B) 237.55 KB
/user/profile/[username] 178.41 KB (-9 B) 282.57 KB
/user/settings 506.14 KB (🟡 +425 B) 610.3 KB
/uuid/recycle-bin 86.15 KB (-8 B) 190.31 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 3 weeks ago

unrelated, but if the popup gets to long it is not usable any more

image
elbotho commented 3 weeks ago

Unrelated UX/UI stuff: button has no hover effect and text of button does not make sense if I edit an existing zone.

image

Also makes me unsure what happens if I close the popup (Actually everything is changes already and I never have to press the button)

elbotho commented 3 weeks ago

unrelated ux: settings and plus buttons get really small.

image

Also: They don't have tooltips.