search

serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
35 stars 9 forks source link

refactor(event): delete RemoveEntityLink #3904

Closed hugotiburtino closed 2 weeks ago

hugotiburtino commented 2 weeks ago

It's causing a bug in the notifications and the event will anyway stop to exist after merging the course pages. So it was already removed from api, see https://github.com/serlo/api.serlo.org/pull/1607

By the way, it could go directly to production, but I'll leave the decision for the frontend people.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jun 24, 2024 7:03am
github-actions[bot] commented 2 weeks ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.26 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 507.31 KB (-10 B) 611.57 KB
/biologie 160.1 KB (🟢 -47 B) 264.36 KB
/chemie 160.1 KB (🟢 -47 B) 264.36 KB
/entity/create/[type]/[taxonomyId] 508.27 KB (-12 B) 612.53 KB
/entity/repository/add-revision/[...id] 507.53 KB (-8 B) 611.79 KB
/entity/taxonomy/update/[id] 69.22 KB (🟢 -8 B) 173.48 KB
/event/history 131.45 KB (🟢 -69 B) 235.71 KB
/event/history/[...slug] 132.44 KB (🟢 -69 B) 236.7 KB
/event/history/user/profile/[username] 134.83 KB (🟢 -69 B) 239.09 KB
/informatik 160.1 KB (🟢 -47 B) 264.36 KB
/lerntipps 160.1 KB (🟢 -47 B) 264.36 KB
/mathe 160.1 KB (🟢 -47 B) 264.36 KB
/nachhaltigkeit 160.1 KB (🟢 -47 B) 264.36 KB
/page/create 507.54 KB (-17 B) 611.8 KB
/subscriptions/manage 114.24 KB (🟢 -47 B) 218.5 KB
/taxonomy/term/create/[parent_id]/[id] 507.32 KB (-6 B) 611.58 KB
/taxonomy/term/update/[id] 507.26 KB (-7 B) 611.52 KB
/user/notifications 133.71 KB (🟢 -69 B) 237.97 KB
/user/profile/[username] 178.72 KB (🟢 -69 B) 282.98 KB
/user/settings 506.48 KB (-33 B) 610.74 KB
/uuid/recycle-bin 86.52 KB (🟢 -14 B) 190.78 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 2 weeks ago

thank you @hugotiburtino I will deploy a minimal version of this to prod now