search

serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
35 stars 9 forks source link

feat(image-plugin-redesign): Add licence selection to image plugin settings #3923

Open shn-srl opened 1 week ago

shn-srl commented 1 week ago

closes https://github.com/serlo/produktentwicklung/issues/14 Issue Link: https://github.com/orgs/serlo/projects/45/views/8?pane=issue&itemId=65345579

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jul 10, 2024 3:58pm
github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.41 KB (🟡 +91 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 84.72 KB (🟢 -80 B) 189.12 KB
/404 41.24 KB (🟢 -80 B) 145.64 KB
/500 41.24 KB (🟢 -79 B) 145.64 KB
/[...slug] 84.73 KB (🟢 -67 B) 189.13 KB
/___bot_or_not 97.54 KB (🟢 -499 B) 201.95 KB
/___cf_not_found 39.47 KB (🟢 -79 B) 143.88 KB
/___design 144.78 KB (🟢 -81 B) 249.18 KB
/___editor_preview 529.55 KB (🟡 +21.51 KB) 633.95 KB
/___graphql 271.86 KB (🟡 +1 B) 376.26 KB
/___old_comments 102.51 KB (🟢 -85 B) 206.92 KB
/auth/___activate_vidis 40.66 KB (🟢 -80 B) 145.06 KB
/auth/error 63.06 KB (🟢 -80 B) 167.46 KB
/auth/login 91.63 KB (🟢 -80 B) 196.04 KB
/auth/logout 81.65 KB (🟢 -79 B) 186.05 KB
/auth/oauth/consent 57.34 KB (🟢 -80 B) 161.75 KB
/auth/oauth/login 91.63 KB (🟢 -80 B) 196.04 KB
/auth/oauth/logout 81.65 KB (🟢 -81 B) 186.06 KB
/auth/recovery 73.13 KB (🟢 -80 B) 177.53 KB
/auth/registration 74.05 KB (🟢 -79 B) 178.45 KB
/auth/settings 74.14 KB (🟢 -80 B) 178.55 KB
/auth/verification 73.46 KB (🟢 -79 B) 177.87 KB
/authorization/roles 69.14 KB (🟢 -80 B) 173.54 KB
/backend 41.53 KB (🟢 -80 B) 145.94 KB
/biologie 160.17 KB (🟢 -72 B) 264.57 KB
/chemie 160.16 KB (🟢 -72 B) 264.57 KB
/consent 40.07 KB (🟢 -80 B) 144.47 KB
/content-only/[...slug] 75.24 KB (🟢 -67 B) 179.65 KB
/discussions 98.8 KB (🟢 -85 B) 203.2 KB
/editor 108.16 KB (🟢 -72 B) 212.56 KB
/entity/create/[type]/[taxonomyId] 530.86 KB (🟡 +21.51 KB) 635.26 KB
/entity/license/update/[id] 59.29 KB (🟢 -79 B) 163.69 KB
/entity/repository/add-revision/[...id] 530.12 KB (🟡 +21.51 KB) 634.53 KB
/entity/repository/compare/[entity_id]/[revision_id] 87.65 KB (🟢 -68 B) 192.05 KB
/entity/repository/history/[id] 72.72 KB (🟢 -80 B) 177.13 KB
/entity/taxonomy/update/[id] 71.8 KB (🟢 -80 B) 176.2 KB
/entity/unrevised 46.34 KB (🟢 -80 B) 150.75 KB
/event/history 134.38 KB (🟢 -161 B) 238.79 KB
/event/history/[...slug] 135.37 KB (🟢 -150 B) 239.77 KB
/event/history/user/profile/[username] 137.75 KB (🟢 -139 B) 242.16 KB
/gleichungs-app 163.55 KB (🟢 -80 B) 267.96 KB
/informatik 160.17 KB (🟢 -73 B) 264.57 KB
/jobs/[[...jobId]] 50.75 KB (🟢 -75 B) 155.15 KB
/legal 39.54 KB (🟢 -80 B) 143.95 KB
/lerntipps 160.17 KB (🟢 -72 B) 264.57 KB
/license/detail/[id] 62.88 KB (🟢 -73 B) 167.29 KB
/mathe 160.16 KB (🟢 -71 B) 264.57 KB
/mathe-aufgaben 40.26 KB (🟢 -80 B) 144.66 KB
/mathe-pruefungen/[region] 76.61 KB (🟢 -81 B) 181.02 KB
/metadata 49.23 KB (🟢 -80 B) 153.64 KB
/nachhaltigkeit 160.17 KB (🟢 -71 B) 264.58 KB
/page/create 530.14 KB (🟡 +21.51 KB) 634.54 KB
/pages 60.6 KB (🟢 -81 B) 165 KB
/privacy 42.88 KB (🟢 -80 B) 147.29 KB
/search 41.53 KB (🟢 -79 B) 145.94 KB
/spenden 54.28 KB (🟢 -80 B) 158.69 KB
/subscriptions/manage 117.15 KB (🟢 -77 B) 221.56 KB
/taxonomy/term/[copyOrMove]/batch/[id] 74.39 KB (🟢 -80 B) 178.79 KB
/taxonomy/term/create/[parent_id]/[id] 529.91 KB (🟡 +21.53 KB) 634.31 KB
/taxonomy/term/sort/entities/[id] 96.18 KB (🟢 -79 B) 200.58 KB
/taxonomy/term/update/[id] 529.84 KB (🟡 +21.52 KB) 634.25 KB
/terms 39.57 KB (🟢 -79 B) 143.97 KB
/user/[...userslug] 39.37 KB (🟢 -80 B) 143.77 KB
/user/me 39.35 KB (🟢 -80 B) 143.76 KB
/user/notifications 136.63 KB (🟢 -164 B) 241.03 KB
/user/profile/[username] 182.98 KB (🟡 +3.01 KB) 287.39 KB
/user/settings 528.67 KB (🟡 +21.49 KB) 633.08 KB
/uuid/recycle-bin 89.29 KB (🟢 -80 B) 193.69 KB
/wallet 42.13 KB (🟢 -78 B) 146.54 KB
/willkommen 86.62 KB (🟡 +3.49 KB) 191.03 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 1 week ago

A Demo Link helps me a lot when reviewing or testing ✌️

shn-srl commented 1 week ago

A Demo Link helps me a lot when reviewing or testing ✌️

Thanks, noted for next time :+1: :pray:

shn-srl commented 1 week ago

Note: e2e tests failing for dropzone image plugin and video + injection, investigating

image

elbotho commented 1 week ago

Bit unrelated, but settings modal is quite low now and could easily be clipped on smaller screens:

image
shn-srl commented 7 hours ago

I would prefer the license info in another place as I explained in my comment.

Also the keyboard experience is still completely broken for me in the select component. Key events get passed down so using arrow keys focused the next plugin and somehow breaks the whole editor. Enter and Escape also close the popup instead of interacting with the select and also break the editor. Not sure why that is happening. (current chromium) Honestly I prefer the less pretty native dropdown that actually works instead of this component if it's not reliable and accessible.

I've improved the behaviour related to keyboard. Let's maybe take a look together if its still at an unacceptable point for you?