search

serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
34 stars 9 forks source link

editor: remove showToastNotice apps/web dependency #3927

Open hejtful opened 3 days ago

hejtful commented 3 days ago

The editor is still importing this error handling helper function from serlo.org website.

import { showToastNotice } from '@/helper/show-toast-notice'

For now, it's alright to make the react-hot-toast package a dependency for the editor and duplicate the helper. Afterwards, the editor might get its own redesigned error handling.

elbotho commented 3 days ago

imho one of the nicer handlers we have :) nice dx and only 29 lines of code aside from the react-hot-toast dependency. Would be no problem to duplicate this in the editor if it helps.