search

serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
39 stars 10 forks source link

fix(image-gallery): lightbox desktop caption below image #4119

Closed hejtful closed 2 weeks ago

hejtful commented 2 weeks ago

Relevant comment: https://linear.app/serlo/issue/PE-57/lightbox-desktop#comment-00744ea7

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Sep 18, 2024 2:26pm
github-actions[bot] commented 2 weeks ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 84.71 KB (-3 B) 189.53 KB
/___bot_or_not 99.81 KB (-3 B) 204.62 KB
/___editor_preview 551.13 KB (-3 B) 655.95 KB
/biologie 162.98 KB (-3 B) 267.8 KB
/chemie 162.98 KB (-3 B) 267.8 KB
/content-only/[...slug] 76.81 KB (-3 B) 181.63 KB
/editor 77.62 KB (-3 B) 182.44 KB
/entity/create/[type]/[taxonomyId] 552.58 KB (-3 B) 657.4 KB
/entity/repository/add-revision/[...id] 551.83 KB (-3 B) 656.65 KB
/entity/repository/compare/[entity_id]/[revision_id] 89.52 KB (-3 B) 194.34 KB
/informatik 162.99 KB (-3 B) 267.8 KB
/lerntipps 162.98 KB (-3 B) 267.8 KB
/license/detail/[id] 64.75 KB (-3 B) 169.57 KB
/mathe 162.98 KB (-3 B) 267.8 KB
/nachhaltigkeit 162.99 KB (-3 B) 267.81 KB
/page/create 551.84 KB (-3 B) 656.66 KB
/taxonomy/term/create/[parent_id]/[id] 551.57 KB (-3 B) 656.39 KB
/taxonomy/term/update/[id] 551.49 KB (-3 B) 656.31 KB
/user/profile/[username] 186.33 KB (-3 B) 291.15 KB
/user/settings 550.67 KB (-3 B) 655.49 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 2 weeks ago

I will resolve the conflict