serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
39 stars 10 forks source link

feat(exercise): always show exercise UI when exercise or children are focused #4126

Closed elbotho closed 1 week ago

elbotho commented 2 weeks ago

PE-166

Demo

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Sep 24, 2024 8:18am
github-actions[bot] commented 2 weeks ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.51 KB (🟡 +12 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 84.73 KB (-1 B) 189.24 KB
/___bot_or_not 99.49 KB (-1 B) 204 KB
/___editor_preview 547.15 KB (-35 B) 651.66 KB
/biologie 162.32 KB (-1 B) 266.83 KB
/chemie 162.32 KB (-1 B) 266.83 KB
/content-only/[...slug] 76.8 KB (-1 B) 181.31 KB
/editor 77.61 KB (🟡 +1 B) 182.13 KB
/entity/create/[type]/[taxonomyId] 549.41 KB (-33 B) 653.92 KB
/entity/repository/add-revision/[...id] 549.09 KB (-35 B) 653.6 KB
/entity/repository/compare/[entity_id]/[revision_id] 89.52 KB (-1 B) 194.03 KB
/informatik 162.33 KB (-1 B) 266.84 KB
/lerntipps 162.32 KB (-1 B) 266.83 KB
/license/detail/[id] 64.73 KB (-1 B) 169.25 KB
/mathe 162.32 KB (-1 B) 266.83 KB
/nachhaltigkeit 162.33 KB (-1 B) 266.84 KB
/page/create 549.1 KB (-36 B) 653.61 KB
/privacy 42.61 KB (-1 B) 147.12 KB
/taxonomy/term/create/[parent_id]/[id] 548.84 KB (-36 B) 653.35 KB
/taxonomy/term/update/[id] 548.75 KB (-37 B) 653.26 KB
/user/profile/[username] 185.24 KB (-1 B) 289.75 KB
/user/settings 547.96 KB (-36 B) 652.47 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

elbotho commented 1 week ago

It actually looks cleaner with both toolbars visible, amazing :)

Nice, next PR will remove the double exercise toolbars again for maximum cleanliness ;)