serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
38 stars 10 forks source link

Improve printing experience #602

Closed elbotho closed 3 years ago

elbotho commented 4 years ago

(follow up of #589)

Problems:

Ideas: Try onbeforeprint

In the issue I mentioned some "research" I did. Even onbeforeprint doesn't look to promising, we could probably get some browsers to work, but not all. Same with the footnotes, we need to check if we could run some JS before the print dialog is open and the print content is set. Should we then just not show the URLs then for now? (Like we do currently)

Extend lazyload implementation

If we change the lazy load implementation to set a state one all of them loaded we could make the UX a bit nicer.

Add a printversion using a flag

Entkenntnis commented 3 years ago

Compared to the legacy system, the frontend isn't too bad.

Some missing features I have noticed:

Anyway, maybe we can find a way to hide the printing warning after the user scrolled to the bottom.

Just some ideas, priority is low.

elbotho commented 3 years ago

(hide comments)

Entkenntnis commented 3 years ago

Hiding comments is doable, see #869, but the rest is - as far as I can see - not achievable without a separate print version of the page - which would be a bigger feature and I'm not sure if this is currently needed.

For more context, see https://github.com/serlo/serlo.org-rfcs/issues/18