serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
38 stars 10 forks source link

Enable revisions in production #802

Closed Entkenntnis closed 3 years ago

Entkenntnis commented 3 years ago

The new revision view is ready (and as good as the existing view). Todo: Take a look that everything is fine and then enable in production (-> create cf issue)

elbotho commented 3 years ago

see https://github.com/serlo/serlo.org-cloudflare-worker/pull/151 as preparation (while we test).

kulla commented 3 years ago

https://github.com/serlo/serlo.org-cloudflare-worker/pull/151 is merged in deployed at staging. Happy testing :smile:

elbotho commented 3 years ago

Thank you!

Entkenntnis commented 3 years ago

Some weird behavior when opening this page: https://de.serlo-staging.dev/32769

Entkenntnis commented 3 years ago

Can we maybe hide meta-changes (title, description) if they are empty? Because I'm not seeing this fields in legacy very often?

elbotho commented 3 years ago

Can we maybe hide meta-changes (title, description) if they are empty?

Yeah good idea

Entkenntnis commented 3 years ago

Not working for grouped exercises: https://frontend.serlo.org/entity/repository/compare/0/193382 and solutions: https://frontend.serlo.org/entity/repository/compare/0/193383

elbotho commented 3 years ago

@Entkenntnis thanks for checking this! This means all other content types work?

elbotho commented 3 years ago

what a goose chase… convert-edtr-io-state does not support exercise. -_-

Entkenntnis commented 3 years ago

Oh right, there is a separate create-exercise handler for this because exercises are complex.

Entkenntnis commented 3 years ago

A side note: Showing the revision of solution is not very useful without the exercise, but if you change the exercise and the solution, the solution revision can't find the corresponding exercise revision (because it's not accepted yet) ... which makes reviewing exercises at times annoying. But this is also happening on legacy now...

Quickfix: Maybe we can at least link to the exercise in a solution or the exercise-group for a grouped exercise. (I can help here, because I think revisions are quite important for authors)

elbotho commented 3 years ago

and solutions

@Entkenntnis I have a vage memory that we wanted to only support editing exercise and solution at the same time?

Entkenntnis commented 3 years ago

Immediate follow-up issue is #919.