search

serlo / serlo-bot

Apache License 2.0
1 stars 0 forks source link

Some entity revisions have content without field 'caption' #10

Closed hugotiburtino closed 3 months ago

hugotiburtino commented 2 years ago

Reported by Anne

What's wrong?

Some 'empty' revisions happen, i.e. unrevised revisions that do not actually have any change for the end user.

Steps to reproduce:

  1. Choose an exercise part with solutions.
  2. Edit only the solution, not the exercise. Save.
  3. In the unrevised changes you are going to see two new entries, the one for the exercise, the other for the solution. It was expected to see only the one for the solution.
  4. Click to see changes of the exercise. Both will be almost same, the newest one may have a minor layout difference.

Reason

Some entity revisions have content without field 'caption'. After comparing the last and the newest revision we se some difference like the following in the content field:

"{\"plugin\":\"exercise\",\"state\":{\"content\":{\"plugin\":\"rows\",\"state\":[{\"plugin\":\"rows\",\"state\":[{\"plugin\":\"text\",\"state\":[{\"type\":\"p\",\"children\":[{\"type\":\"math\",\"src\":\"\\\\gamma = 90^\\\\circ\",\"inline\":false,\"children\":[{\"text\":\"\\\\gamma = 90^\\\\circ\"}]},{\"type\":\"math\",\"src\":\"a=12{,}7\\\\,\\\\mathrm{cm}\",\"inline\":false,\"children\":[{\"text\":\"a=12{,}7\\\\,\\\\mathrm{cm}\"}]},{\"type\":\"math\",\"src\":\"c= 24{,}9\\\\,\\\\mathrm{cm}\",\"inline\":false,\"children\":[{\"text\":\"c= 24{,}9\\\\,\\\\mathrm{cm}\"}]}]}]},{\"plugin\":\"image\",\"state\":{\"src\":\"https://assets.serlo.org/legacy/5735b83f60173_4ead02dfd1a6f94e22fd9953d367fe7d7f0d15c4.png\",\"alt\":\"\"}}]}]}}}"

"{\"plugin\":\"exercise\",\"state\":{\"content\":{\"plugin\":\"rows\",\"state\":[{\"plugin\":\"rows\",\"state\":[{\"plugin\":\"text\",\"state\":[{\"type\":\"p\",\"children\":[{\"type\":\"math\",\"src\":\"\\\\gamma = 90^\\\\circ\",\"inline\":false,\"children\":[{\"text\":\"\\\\gamma = 90^\\\\circ\"}]},{\"type\":\"math\",\"src\":\"a=12{,}7\\\\,\\\\mathrm{cm}\",\"inline\":false,\"children\":[{\"text\":\"a=12{,}7\\\\,\\\\mathrm{cm}\"}]},{\"type\":\"math\",\"src\":\"c= 24{,}9\\\\,\\\\mathrm{cm}\",\"inline\":false,\"children\":[{\"text\":\"c= 24{,}9\\\\,\\\\mathrm{cm}\"}]}]}]},{\"plugin\":\"image\",\"state\":{\"src\":\"https://assets.serlo.org/legacy/5735b83f60173_4ead02dfd1a6f94e22fd9953d367fe7d7f0d15c4.png\",\"alt\":\"\",\"caption\":{\"plugin\":\"text\",\"state\":[{\"type\":\"p\",\"children\":[{}]}]}}}]}]}}}"

References serlo/serlo.org-legacy#720 serlo/serlo.org-legacy#721