Geogebra embed does not size itself correctly based on its container element size

serlo / serlo-editor-for-edusharing

https://serlo-editor-for-edusharing.vercel.app

Apache License 2.0

4 stars 3 forks source link

Geogebra embed does not size itself correctly based on its container element size #301

Closed LarsTheGlidingSquirrel closed 9 months ago

LarsTheGlidingSquirrel commented 10 months ago

Geogebra plugin is currently deactivated because of this issue.

Currently, the geogebra embed sizes itself to have height: 0. Even though the container element does not provide a height itself, only the width.

Steps to reproduce on branch https://github.com/serlo/serlo-editor-for-edusharing/tree/fix-geogebra:

Run yarn dev
Open localhost:8100
Create Geogebra element
Enter some id, for example: nv5wNx9R
Geogebra embed appears in editor and looks good
Click 'Speichern'
Set mayEdit=false in Url to load read-only view (uses "static renderer" here)

Geogebra embed has size 0 here.

elbotho commented 10 months ago

the plugin implicitly depends on styling provided by the privacy wrapper in the frontend. Easiest way would probably be to add the missing wrappers/elements here as well.

Entkenntnis commented 9 months ago

The links PR will fix the seizing issue itself.

There are two other issues that are independant of it and also prevent geogebra from displaying properly and in my knowledge happen in the frontend as well:

The detection of empty media element has an edge case that will not detect geogebra properly and hide it (see screenshot). That's the reason why the plugin is not visible if content is empty
You can't add two plugins with the same id - the second one will not load (probably because we are using the id as index internally)