serlo / serlo-export

Export Serlo.org and Mathe für Nicht-Freaks articles into various output formats
https://de.serlo.org/
Apache License 2.0
5 stars 1 forks source link

Avoid nesting of semantic blocks #69

Closed Lodifice closed 7 years ago

Lodifice commented 7 years ago

If semantic blocks are nested, the frame (i.e., the blue line to the left) is drawn twice. This does not only look ugly, but once we add icons, they will be placed on top of the line of the outer block.

An example is here where an important paragraph is nested in a solution process (for some strange reason it inherits the frame title of the outer environment, but is otherwise typeset correctly - blue color).

kulla commented 7 years ago

Nested semantic boxes is an error and shall be replaced by {type: error, message: ...}

kulla commented 7 years ago

https://github.com/Lodifice/mfnf-pdf-export/commit/e19cd5b5c66a7bb8462eed702f4ad3ed43ad2f01 Should solve this issue...