serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/
https://serlo.org/
Apache License 2.0
18 stars 3 forks source link

server: Remove unused module CacheInvalidator #547

Closed kulla closed 3 years ago

kulla commented 3 years ago

The module CacheInvalidator was disabled 2015 by the commit https://github.com/serlo/athene2/commit/8258e804bb0f963ea3a394c31b5fd919c39d3759 and was not reused afterwards. Thus we can remove this module since there are currently no listener in this module active. Since cache_listener does not exists the list $options is empty:

https://github.com/serlo/serlo.org/blob/b142eb5dfa1d85991dd51efff46c3d7536f95695/packages/public/server/src/module/CacheInvalidator/src/Factory/CacheOptionsFactory.php#L33-L37

This results in CacheOptions->getListen() to be empty: https://github.com/serlo/serlo.org/blob/b142eb5dfa1d85991dd51efff46c3d7536f95695/packages/public/server/src/module/CacheInvalidator/src/Options/CacheOptions.php#L32

Thus no listener are activated: https://github.com/serlo/serlo.org/blob/b142eb5dfa1d85991dd51efff46c3d7536f95695/packages/public/server/src/module/CacheInvalidator/src/Listener/CacheListener.php#L67-L82

I have not found a usage outside this module.