search

serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/
https://serlo.org/
Apache License 2.0
18 stars 3 forks source link

Navigation of a Spanish course not shown #559

Closed kulla closed 3 years ago

kulla commented 3 years ago

See https://es.serlo.org/community/recursos-para-educadores/serlo.org---tutorial-para-familiarizarse/chat-para-todas-las-preguntas

In legacy version there is no navigation. However in the new design it is shown.

inyono commented 3 years ago

Wild guess: there's a trailing space in the navi backend somewhere -.-

kulla commented 3 years ago

Wild guess: there's a trailing space in the navi backend somewhere -.-

@jakobwes Can you check this?

jakobwes commented 3 years ago

Just had a look at it (a bit late: sorry for that). We didn't yet implement the topic-navigation for the community-subject in the backend (What in German and English you would have under "Community Overview"). Maybe it is related to that?

If so: is there on option of linking the taxonomy with the navigation, without having a label "Community Overview" always in the menu for everything under /community? I think this label doesn't really tell much to the users, which have no real reason to ever see the taxonomy-root of all content under /community (this page here: https://es.serlo.org/community/164234/community).

inyono commented 3 years ago

Well, the Taxonomy\Provider\NavigationProvider is essential for the navigation to work (as the name might suggest ^^). If you want a navigation (with e.g. breadcrumbs), you'll need that.

jakobwes commented 3 years ago

Okay, that's fair ^^. Is there then a way of implementing it, without having another label in the left menu, or not showing this label? If not then I can also just implement it and then when the new frontend launches we can take it out, since there the linking between navigation and taxonomy seems to be automatic.

kulla commented 3 years ago

I can also just implement it and then when the new frontend launches we can take it out, since there the linking between navigation and taxonomy seems to be automatic.

I think that is the best solution.

CarolinJaser commented 3 years ago

This is not relevant any longer since it does not occur in the new frontend. Since we are very close to switching to 100% new frontend anyway, I am closing this issue