edtr-io: Add support for cohesive exercise groups

serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/

https://serlo.org/

Apache License 2.0

18 stars 3 forks source link

Closed kulla closed 3 years ago

kulla commented 3 years ago

@inyono A first feedback would be great since it is the first time I change an edtr-io plugin :smile:

Missing:

[ ] Add translation strings
[ ] When an cohesive exercise group got included via an injection it should be included with its subexercises and solutions

Current preview:

kulla commented 3 years ago

@inyono I am ready for new feedback ( and I have some questions, can we have a call?). My questions:

How do I upload the newly created translation strings to crowdin?
Is packages/private/edtr-io/src/plugins/types/text-exercise-group.tsx also used to render the content outside of the editor? I do not see the changes of the numbering there...

inyono commented 3 years ago

What's the state of this PR? Ready for review?

kulla commented 3 years ago

What's the state of this PR? Ready for review?

Yes. Also ready for merge. I decided that saving cohesive as a parameter to entity is the best way currently.