search

serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/
https://serlo.org/
Apache License 2.0
18 stars 3 forks source link

license notice in edtr.io missing for for content under other licenses #624

Closed ghost closed 3 years ago

ghost commented 3 years ago

E.g. serlo.org/11199: If I edit the content, before saving the usual text about agreeing to the terms is missing, but you still have the mark the checkbox. Screenshot_2021-04-28 Serlo – Die freie Lernplattform

Normally this text appears Screenshot_2021-04-28 Serlo – Die freie Lernplattform(1)

For the example mentioned above parts of the exercise is not licensed under our standard license. May that be the reason?

inyono commented 3 years ago

Not sure if this is the case here, but: this usually happens, when the license itself doesn't have a license text attached (which is often the case for non-CC licenses because someone only created them without adding some description). If so, we should add a description for those licenses, we have in use. We might be able to add a fallback if necessary (something like "this content is licensed under foo. Don't edit if you don't know what this entails)

ghost commented 3 years ago

Thanks for the explanation. I just found the corresponding field in the license backend where to add the description. Therefore I will close the issue again.