search

serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/
https://serlo.org/
Apache License 2.0
18 stars 3 forks source link

Remove route /user/public #647

Closed kulla closed 3 years ago

kulla commented 3 years ago

Follow up of https://github.com/serlo/serlo.org-cloudflare-worker/pull/209 with which the route /user/public can never be reached.

inyono commented 3 years ago

Does this also work correctly for logged-in users (that may be redirected to the legacy frontend at the moment)?

Entkenntnis commented 3 years ago

"Eigenes Profil" directs to user profile directly, without /user/public, so frontend is fine

inyono commented 3 years ago

"Eigenes Profil" directs to user profile directly, without /user/public, so frontend is fine

I'm talking about legacy. I.e. does it work for users that are logged in and are still served the legacy system.

kulla commented 3 years ago

Does this also work correctly for logged-in users (that may be redirected to the legacy frontend at the moment)?

Yes. /user/public is a redirect to the profile route /user/:id/:username which is the same as /user/me without the navigation left with buttons like change password, edit profile, etc. This PR would delete the button public profile and thus it would be harder for users to get to their public profile view without navigation. However I think that's okay (since they see everything) and it is planned to serve the new design to all logged in users in two weeks anyway...

kulla commented 3 years ago

(In the new design there is no distinction between a view on the user profile without and with a navigation -> both views are integrated in one)