serlo / serlo.org-legacy

Legacy implementation of https://serlo.org/
https://serlo.org/
Apache License 2.0
18 stars 3 forks source link

API: Remove cache instead of updating it #658

Closed kulla closed 3 years ago

kulla commented 3 years ago

Closes https://github.com/serlo/serlo.org/issues/657

kulla commented 3 years ago

Shouldn't we be able to remove setUuid?

I only removed setUuid() at places where entities might be envolved. Here is the remaining changes: https://github.com/serlo/serlo.org/pull/659 Maybe we want to wait to see how the effects will be in production...

kulla commented 3 years ago

@inyono What do you when we change removeKey to updateKey so that the key get's updated via SWR?

inyono commented 3 years ago

@inyono What do you when we change removeKey to updateKey so that the key get's updated via SWR?

We could do that, sure.

kulla commented 3 years ago

@inyono This PR is now also live in production. When everything works fine we can also merge https://github.com/serlo/serlo.org/pull/659