store heartbeat use redis setex with wrong timeunit

sermant-io / Sermant

CNCF sandbox project, a Cloud-Native Proxyless Service Mesh based on Java Bytecode Enhancement Technology

https://sermant.io/

Apache License 2.0

1.25k stars 164 forks source link

store heartbeat use redis setex with wrong timeunit #1610

Closed AYue-94 closed 2 months ago

AYue-94 commented 2 months ago

What happened?

max.effective.time=60000, the time unit is milliseconds. when store heartbeat use redis setex command, directly set ttl as 60000 seconds.

How can we reproduce it (as minimally and precisely as possible)?

just start an agent to send heartbeat.

Anything else we need to know?

No response

Sermant version

2.0.0

OS version

MacOS 14.1

AYue-94 commented 2 months ago

i will try to fix it

lilai23 commented 2 months ago

i will try to fix it

Thanks for find and fix this issue

lilai23 commented 2 months ago

@AYue-94 I have found you are not in our contributers now. Confirm your email of GitHub account is the same as your email when you commit your codes. It may happen for this reason