sermant-io / Sermant

CNCF sandbox project, a Cloud-Native Proxyless Service Mesh based on Java Bytecode Enhancement Technology
https://sermant.io/
Apache License 2.0
1.25k stars 164 forks source link

Fixed an issue where DubboProviderInterceptor remove tag on the consumer side. As a result, the traffic tag is removed and cannot be obtained from thread local #1661

Closed hanbingleixue closed 1 day ago

hanbingleixue commented 1 day ago

What type of PR is this?

Bug

What this PR does / why we need it?

Fix remove tag issue for DubboProviderInterceptor in consumer side ,it will cause previously traffic tag removed and the follow up invocation can not get traffic tag from thread local.

This PR is copied from #1652 to fix this issue in later releases of 2.1.x

Which issue(s) this PR fixes?

Fixes #1654

Does this PR introduce a user-facing change?

No

Checklist

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../interceptors/AlibabaDubboProviderInterceptor.java 50.00% 2 Missing :warning:
...2/interceptors/ApacheDubboProviderInterceptor.java 50.00% 2 Missing :warning:
...3/interceptors/ApacheDubboProviderInterceptor.java 50.00% 2 Missing :warning:
Flag Coverage Δ Complexity Δ
unittests 44.20% <50.00%> (+<0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../interceptors/AlibabaDubboProviderInterceptor.java 65.00% <50.00%> (-1.67%) 0.00 <0.00> (ø)
...2/interceptors/ApacheDubboProviderInterceptor.java 67.56% <50.00%> (-2.13%) 0.00 <0.00> (ø)
...3/interceptors/ApacheDubboProviderInterceptor.java 68.42% <50.00%> (-2.17%) 0.00 <0.00> (ø)
Issues-translate-bot commented 1 day ago

Detect the issue's language is not English and translate it automatically.


Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../interceptors/AlibabaDubboProviderInterceptor.java 50.00% 2 Missing :warning:
...2/interceptors/ApacheDubboProviderInterceptor.java 50.00% 2 Missing :warning:
...3/interceptors/ApacheDubboProviderInterceptor.java 50.00% 2 Missing :warning:
Flag Coverage Δ Complexity Δ
unittests 44.20% <50.00%> (+<0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../interceptors/AlibabaDubboProviderInterceptor.java 65.00% <50.00%> (-1.67%) 0.00 <0.00> (ø)
...2/interceptors/ApacheDubboProviderInterceptor.java 67.56% <50.00%> (-2.13%) 0.00 <0.00> (ø)
...3/interceptors/ApacheDubboProviderInterceptor.java 68.42% <50.00%> (-2.17%) 0.00 <0.00> (ø)