search

serokell / coffer

Multi-backend password store with multiple frontends
4 stars 2 forks source link

[#9] Directory check in `create` command #10

Closed DK318 closed 2 years ago

DK318 commented 2 years ago

Problem: we can create entries and directories with the same names. Solution: added subfunction checkForEntriesInEntryPath which tries to find an existing entry subpath in given path. Then checked if the given entry path is an existing directory or contains existing entries in subpaths.

MagicRB commented 2 years ago

Sorry, the problem/solution should be in the commit itself, as long description. Ill link you a doc

dcastro commented 2 years ago

Good work! Just needs a bit of polishing and we're good to go.

Also great work in identifying yet another issue: the fact that we need to check all parent dirs, not just the target dir! :clap:

Thanks for tagging the PR's title and the commit messages with the issue number [#x]