[#104] Web API integration tests - Githubissues

serokell / coffer

Multi-backend password store with multiple frontends

4 stars 2 forks source link

[#104] Web API integration tests #109

Closed DK318 closed 2 years ago

DK318 commented 2 years ago

Description

Some integration tests for Web API.

Related issue(s)

Fixes #104.

Fixed #

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Tests
- [ ] If I added new functionality, I added tests covering it.
- [ ] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
Documentation
- [ ] I checked whether I should update the docs and did so if necessary:
- README
- Haddock

Stylistic guide (mandatory)

[x] My commits comply with the policy used in Serokell.
[x] My code complies with the style guide.

dcastro commented 2 years ago

Good job! :+1:

DK318 commented 2 years ago

But tests have many hard-coded values like ports & etc. that could be dragged out to constants at least

We can do some refactoring in #105