[#85] make the port number configurable - Githubissues

serokell / coffer

Multi-backend password store with multiple frontends

4 stars 2 forks source link

[#85] make the port number configurable #126

Closed Kariel-Myrr closed 2 years ago

Kariel-Myrr commented 2 years ago

Description

Motivation: Server port wasn't configurable. We want to be able specify it via cmd line option or environment variable

Solution: Implement configuration by cmd option(stronger) & env variable for port

in lib:
- added serverOption
- added lookup for env var 'COFFER_SERVER_PORT'
in tests -> server-integration
- added cmd option with 8081 port
- added tests for port configuration (tests based on 8079 port)

Related issue(s)

Fixed #85

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Tests
- [x] If I added new functionality, I added tests covering it.
- [ ] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
Documentation
- [x] I checked whether I should update the docs and did so if necessary:
- README
- Haddock

Stylistic guide (mandatory)

[x] My commits comply with the policy used in Serokell.
[ ] My code complies with the style guide.

dcastro commented 2 years ago

@sancho20021 is no longer working on this project, so I marked his comments as resolved.

I think it's good to be merged now @Kariel-Myrr :+1: