[#65] Make path's charset rules backend specific - Githubissues

serokell / coffer

Multi-backend password store with multiple frontends

4 stars 2 forks source link

[#65] Make path's charset rules backend specific #127

Closed Kariel-Myrr closed 2 years ago

Kariel-Myrr commented 2 years ago

Description

Motivation

We wanted to validate paths not on Path lvl, but on Backend lvl (So each backend validates paths)

Solution

Remove check for allowed symbols
Added check for not containing '#'
Added new Effect of Backend - validatePath
Added validation for paths in Backend.Commands So it's now cmd responsibility to check if path is valid lies on cmd
Updated error msg - now they contain info about specific backend
Added new backend specific tests

Related issue(s)

Fixed #65

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Tests
- [ ] If I added new functionality, I added tests covering it.
- [ ] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
Documentation
- [ ] I checked whether I should update the docs and did so if necessary:
- README
- Haddock

Stylistic guide (mandatory)

[ ] My commits comply with the policy used in Serokell.
[ ] My code complies with the style guide.