search

serokell / coffer

Multi-backend password store with multiple frontends
4 stars 2 forks source link

[#12] Rename command implemented #13

Closed DK318 closed 2 years ago

DK318 commented 2 years ago

Problem: rename command is not implemented. Solution: implemented rename command via copy and delete commands. Fixes: #12

MagicRB commented 2 years ago

IMO it should be moved to the backend as it can be done more efficiently for some backends, namely pass or if we eventually implement our own secret engine in vault.

dcastro commented 2 years ago

IMO it should be moved to the backend as it can be done more efficiently for some backends, namely pass or if we eventually implement our own secret engine in vault.

TBH it's not just this bit, I think a lot of things will be moved to the backend (and some things might be moved in the opposite direction, who knows). But we'll only know for certain when we actually implement those other engines; then we'll have to figure out what they have in common and what they don't, and where the right level of abstraction is.

I think we can leave it here for now and re-evaluate this when it becomes a problem.